Remove unnecessary CSS for shrinking central header area #56220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CSS was necessary before moving the top toolbar into the header DOM. Now that the toolbar is in the header DOM, we can remove this CSS since the width is dynamically handled by flexbox.
|
Size Change: -28 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
getdave
approved these changes
Nov 29, 2023
|
Closed and reopened PR to force the new Playwright - 5 - 8 checks to run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CSS was necessary before moving the top toolbar into the header DOM. Now that the toolbar is in the header DOM, we can remove this CSS since the width is dynamically handled by flexbox.
What?
Removes unnecessary CSS.
Why?
The central area was shrinking based on the top toolbar mode, when it didn't need to.
How?
Removes the CSS that caused the central area to shrink when top toolbar was on.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
Screen.Recording.2023-11-16.at.11.04.24.AM.mov
After
Screen.Recording.2023-11-16.at.11.09.32.AM.mov