DataViews: Update author and title fields in template's list #56029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Experimental
ntsekouras
requested review from
youknowriad,
oandregal,
jameskoster,
SaxonF and
jorgefilipecosta
|
Size Change: +169 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
The screenshot look a bit weird to me, I'm not sure I understand what "Twenty Twenty-Four" means in that screenshot. Should we have icons per source or something like that, how do I know that it's a them and that "admin" is a user. |
That's a good question. Currently there are some defaults for every source to have an icon(theme, plugin, user). With the design suggested(what this PR does) only users have avatars. --cc @jameskoster @SaxonF |
|
I think context plays a role here. The theme name should be familiar, but I don't oppose an icon if there are strong feelings about that. The Gravatar should indicate the author is a person, especially when there's actually an image there rather than a placeholder. |
|
Personally I don't have any strong opinions here.. Probably it's enough as is. @youknowriad what do you think? |
|
To be honest, it doesn't look great to me but then I'm not a designer. While "Twenty Twenty Four" is a clear theme name for anyone that is familiar with WordPress, the theme name can be something very weird and not clear. Anyway, I don't mind if that's a direction designers want to try. |
|
That's how it works now, except there's a @ntsekouras if we make the avatar 24x24 it'll line up nicely with the icons: 
|
ntsekouras
force-pushed
the
update/author-dataviews-templates
branch
from
b4ca051
to
52c6a6f
Compare
This is the before/after. Code changes look good. Text & spacing changes look good. I understood we'd maintain the icon for the theme, though – I'll preapprove, but it'd be good to confirm this. |
oandregal
approved these changes
Nov 16, 2023
youknowriad
approved these changes
Nov 16, 2023
I made this change! Maybe you didn't pull? 🤔 |
oandregal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up of: #55848 (comment)
This PR handles:
Screenshots or screencast