Block Editor: Remove expired __experimentalGroup deprecations and prop #56023
+2
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the release of 6.4, the deprecated old __experimentalGroup prop can now be removed.
aaronrobertshaw
added
[Type] Code Quality
aaronrobertshaw
requested review from
aristath,
talldan,
glendaviesnz and
kevin940726
|
Size Change: -96 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 395b9f1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6818623580
|
|
I wanted to make sure everyone reviewing is aware that it’s going to impact production websites that still use the experimental prop for the group name. In effect, the controls impacted will move to the default group in the sidebar. The fact that the core block had to get refactored as part of the task triggered my feedback. There is no issue with that from the code perspective, but it might disturb the user experience, so it would be good to run a brief check in the plugin directory to see if there is anything to worry about. |
Thanks @gziolo, I'll dig deeper into the plugin directory next week to see what we're looking at 👍 |
|
I like that even if there's a plugin that is already using this won't break with this PR. It will just move to a different part of the toolbar. That said, a look into the plugin directory and some reaching out might be good. |
Unfortunately, it looks like there still could be some breakage. Most of the InspectorControl groups render into a ToolsPanel. Any ToolsPanelItems rendered into the non-advanced/default groups by plugins would be broken. There are a some hits when searching for current uses of The majority of these hits were for It would be good to properly clean up the experimental props but I'm not certain on how best we achieve that. Is there a formal process for reaching out to plugin authors to resolve some of these outstanding uses of cc/ @annezazu |
So sorry for the delay here. Came back from nearly two weeks off and am just now catching up here. I usually just reach out manually and ask folks to look at this PR/share their feedback/get prepared. Sometimes that means doing some internet digging to actually find people. If you'd like, I can handle that this week :) |
That would be amazing, thank you Anne! 🙇 |
|
Reached out to every impacted plugin that has active installs. If there are 0 installs, I didn't reach out (but I can if we want). The only person I couldn't track down is the creator of Custom Content Blocks. The GitHub profile seems to be @alexlundin so noting that here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Completes the removal of the deprecated
__experimentalGroupprop from inspector controls fills and slots.Why?
__experimentalGroupwas stabilised into thegroupprop. With the release of WP 6.4, the deprecation of__experimentalGrouphas expired and can now be removed.How?
__experimentalGroupprop anddeprecated()calls.Testing Instructions
__experimentalGroupin code