Playwright Utils: Fix 'clickBlockOptionsMenuItem' helper #55923
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR fixes a bug where the
editor.clickBlockOptionsMenuItem
helper failed for menu items displaying keyboard shortcodes.Why?
The helper should work with any menu item in the Options dropdown.
How?
Switch to
page.getByRole()
, which uses case-insensitive and substring matching for labels by default.Testing Instructions
The following e2e test case will fail on the trunk: