Image block: don't show pointer cursor on linked image in the editor #55882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. This created a small regression in the editor: the cursor shows the "pointer" style. In this PR we restore cursor style, so it doesn't appear 'clickable'.
ramonjd
added
[Type] Regression
ramonjd
requested review from
artemiomorales and
michalczaplinski
as code owners
|
Size Change: +38 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
glendaviesnz
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Tested well for me.
The only thing I wondered is whether it needs to go in the higher specificity .wp-block-image.wp-block-image selector as it also seems to work if added to the single .wp-block-image selector. Probably doesn't really matter as I can't see it being something people will want to override.
|
Thanks for the quick test @glendaviesnz!
If you think so, happy to update accordingly. The main concern was the visual regression. If the majority of users don't see the little hand cursor then I'm happy 😄 |
Over to you, I don't have a strong opinion on this, I just thought it was a little strange that it ended up as |
Actually, you're right to call it out. I didn't notice the comments at the top of the editor.scss file:
Since this change is not related to the placeholder I'll move the rule to nest under Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In this PR we set the cursor style to "default", so it doesn't appear 'clickable'.
Before
2023-11-06.14.02.01.mp4
After
2023-11-06.14.02.23.mp4
Why?
Since #55470, when an Image block is linked it's wrapped with a disabled tag
This created a small regression in the editor: the cursor shows the "pointer" style.
Testing Instructions
Add an image to a post. Add a link to that image.
Ensure the pointer cursor doesn't appear when you hover over the linked image.
This applies to the editor only, so publish the page and check in the frontend that a pointer cursor appears on the linked image.
Here is some test block code!
Check with a gallery as well