Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary label when no visible filters exist #55838

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Remove unnecessary label when no visible filters exist #55838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 17 additions & 19 deletions packages/edit-site/src/components/dataviews/filters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,26 +49,24 @@ export default function Filters( { fields, view, onChangeView } ) {
} );
} );

return (
view.visibleFilters?.map( ( filterName ) => {
const filter = filterIndex[ filterName ];
return view.visibleFilters?.map( ( filterName ) => {
const filter = filterIndex[ filterName ];

if ( ! filter ) {
return null;
}
if ( ! filter ) {
return null;
}

if ( filter.type === 'enumeration' ) {
return (
<InFilter
key={ filterName }
filter={ filter }
view={ view }
onChangeView={ onChangeView }
/>
);
}
if ( filter.type === 'enumeration' ) {
return (
<InFilter
key={ filterName }
filter={ filter }
view={ view }
onChangeView={ onChangeView }
/>
);
}

return null;
} ) || __( 'No filters available' )
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot of whitespace changes, but the actual change is removing __( 'No filters available' )

);
return null;
} );
}
Loading