Resizeable box (for resizing cover block) should use after block popover slot #55784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +5 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
…ver slot The block-popover slot is reserved for block-toolbar like popovers, such as the captions popover. Popovers that are not block tools should use the __unstable-block-tools-after slot.
scruffian
force-pushed
the
fix/resizeable-box-popover-slot
branch
from
a94bdfe to
a99c7be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Change the slot name used for the resize handles on the cover block resizer.
Why?
The block-popover slot is reserved for block-toolbar like popovers, such as the captions popover. Popovers that are not block tools should use the
__unstable-block-tools-afterslot. This is important for when the Top Toolbar is within the header DOM, as these resize tools should not be within that. Regardless, these tools should be using the__unstable-block-tools-afterslot.How?
Change the slot used by the resizer to the
__unstable-block-tools-afterTesting Instructions
There should be no functional change from
trunk.trunkTesting Instructions for Keyboard
Screenshots or screencast