Chore: Fix: Potential access to properties of undefined object. #55697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
|
Size Change: +1 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 851836e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6692177612
|
jorgefilipecosta
deleted the
fix/Potential-access-to-properties-of-undefined-object
branch
dcalhoun
pushed a commit
that referenced
this pull request
Oct 30, 2023
dcalhoun
pushed a commit
that referenced
this pull request
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our code was assuming that the font family may be undefined in
a?.name || a?.slug. But if a is really undefined we then do( a?.name || a?.slug ).localeCompare( b?.name || a?.slug )which may cause accessing localeCompare of undefined which crashes the editor. If a may be undefined( a?.name || a?.slug )may also be undefined so we need to change( a?.name || a?.slug )to( a?.name || a?.slug )?.