Fix: LinkControl on site editor does not show font page and post page indication #55694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… indication as expected.
jorgefilipecosta
added
the
[Type] Bug
|
Size Change: +73 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
dcalhoun
pushed a commit
that referenced
this pull request
Oct 30, 2023
… indication as expected. (#55694)
dcalhoun
pushed a commit
that referenced
this pull request
Oct 31, 2023
… indication as expected. (#55694)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LinkControl part of the block editor has a UI to show when a page is the front page of a site or the blog page. It is working well on the post editor but it is not working at all on the site editor because some missing block editor settings are missing there. This PR fixes the issue.
cc: @MaggieCabrera as this is a follow-up to a task we previously worked on.
Testing
Go to the site editor.
Add a link e.g.: in a paragraph or button to the front page of a site (select one on reading settings if you have not one yet). Verify the UI correctly shows it is the front page.
Add a link e.g.: in a paragraph or button to the blog page of a site (select one on reading settings if you have not one yet). Verify the UI correctly shows it is the blog page.
Screenshots
Before
After