Block Editor: Optimize alignment toolbar controls #55692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Performance
|
Size Change: +57 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
optimize/block-alignments-toolbar-controls
branch
from
efb74ac to
8d4b854
Compare
|
Thank you, @jsnajdr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A micro-optimization for
aligntoolbar controls to avoid callinguseBlockEditingModeanduseAvailableAlignmentshooks for every block rendered in the editor.Why?
The checks are only needed if the block supports the alignments. Most of the text blocks don't support alignments. Recudes block editor store subscriptions by 1000 in the large text post.
Note: Can't use
props.isSelectedas it would break the__experimentalExposeControlsToChildrenfeature.How?
Move controls and hook into a new component, which only renders when the feature is supported.
Testing Instructions