Edit Post: Fix revision button misalignment #55659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +4 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
Oct 27, 2023
|
Thanks for the review, @jameskoster!
Yes, there may be better approaches in the future 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes the misalignment of the revision button icon and text in the post editor.
Before
After
Why?
The CSS for the Post Editor revision button shouldn't have changed in several years. Perhaps some enhancement to the Button component caused the CSS to have a lower priority than the button component's default style.
How?
Added
.components-buttonclass to increase CSS specificity. This approach can be seen for example here and here.Testing Instructions