Global styles: disable revisions menu item when panel is open #55620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Enhancement
|
Size Change: +18 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Thanks for the quick PR. I don't know that disabling is the right direction here. It's a bit strange to see the "Revision history" button when you're already browsing revisions, but disabling it might lead to more confusion. Part of the problem right now is that clicking the button does nothing when the revisions panel is open which makes it feel a bit broken. As a middle-ground, perhaps we could try: clicking the button closes the popover. What do you think? |
|
Thanks for the PR! Another approach I can imagine is to eliminate the revision button popover. This means that when you press the revision button, this button changes to the "pressed" style and immediately displays the revision panel. Additionally, display a button at the bottom of the panel to quickly return to defaults. In the future, pagination might also appear above this reset button.
|
Thanks! I'll try it out.
I thought about this, and it's definitely worth an attempt - the only UI issue I had was how, or even whether to show the Reset button, around the "Apply button" 
|
I was mistaken about this 😅 The button at the bottom has already been implemented, and when the oldest revision is selected, the "Reset to defaults" button is displayed, otherwise it switches to the "Apply" button. 3db48734b4290aeb0eb00b31b9b6a7c0.mp4My one opinion is to display the buttons side by side. However, some languages will definitely overflow the text, so automatic wrapping may be necessary, as was done in #52249.
That said, perhaps we should explore a little more first in #55486 as to where it would be ideal to place the reset button 🤔 |
|
Thanks for the ideas. I agree it could be addressed more holistically. I might pause this PR pending review of the general Styles panel view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A small PR to disable global styles revisions menu item when the global styles revisions is open
Why?
Remarked upon in #55486 (comment), to provide a visual cue to users that the menu item is active.
How?
Via the
disabledprop on<MenuItem />Testing Instructions
/wp-admin/site-editor.phpTesting Instructions for Keyboard
Screenshots or screencast