Improve Button saving state accessibility.
#55547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
afercia
changed the title
Button saving state accessibility.
|
Size Change: +1.33 kB (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d79707f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6945368659
|
afercia
force-pushed
the
fix/saving-buttons-a11y
branch
from
d66fa1f
to
807520e
Compare
This was referenced Oct 24, 2023
afercia
force-pushed
the
fix/saving-buttons-a11y
branch
from
807520e
to
d79707f
Compare
|
Rebased on top of latest trunk. |
|
The optional check |
jasmussen
reviewed
Nov 21, 2023
| @@ -242,6 +242,9 @@ | |||
| &.is-secondary.is-busy:disabled, | |||
| &.is-secondary.is-busy[aria-disabled="true"] { | |||
| animation: components-button__busy-animation 2500ms infinite linear; | |||
| @media (prefers-reduced-motion: reduce) { | |||
There was a problem hiding this comment.
I think you could use @include reduce-motion("animation"); instead of this whole query.
There was a problem hiding this comment.
@jasmussen thanks, as I mentioned in this PR description:
Note that is not possible to use the reduce-motion mixin because it sets
animation-duration: 1msbut it doesn't resetanimation-iteration-countwhich isinfinitefor this specific animation. I don't know why the reduce-motion mixin doesn't reset all the animation properties to 0 but it would be better to revisit it to have a mixin that is guaranteed to work with all animations / transitions.
There was a problem hiding this comment.
Oh I missed this. Can we update the mixin? I don't see why we shouldn't. If you do, be sure to restart npm run dev for the mixin to take.
There was a problem hiding this comment.
Oh I missed this. Can we update the mixin?
Yes of course, but I'd recommend a separate PR. I did already open #55566 in fact.
There was a problem hiding this comment.
Sounds good to me. At most we could add an inline comment suggesting that we should refactor it to using @include reduce-motion("animation"); as soon as #55566 is closed
Been busy with a few things this past couple of days, I'll try to take a look tomorrow. |
ciampo
approved these changes
Nov 22, 2023
| @@ -242,6 +242,9 @@ | |||
| &.is-secondary.is-busy:disabled, | |||
| &.is-secondary.is-busy[aria-disabled="true"] { | |||
| animation: components-button__busy-animation 2500ms infinite linear; | |||
| @media (prefers-reduced-motion: reduce) { | |||
There was a problem hiding this comment.
Sounds good to me. At most we could add an inline comment suggesting that we should refactor it to using @include reduce-motion("animation"); as soon as #55566 is closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55545
What?
The saving buttons animation doesn't respect the OS-level preference 'Reduce motion'.
Additioanlly, the gray saving button doesn't have a sufficient color contrast ratio.
Why?
All animaitons should be disabled when users enable the OS-level preference 'Reduce motion'. This is even more important for animations that could potentially trigger seizure.
How?
reduce-motionmixin because it setsanimation-duration: 1msbut it doesn't resetanimation-iteration-countwhich isinfinitefor this specific animation. I don't know why thereduce-motionmixin doesn't reset all the animation properties to 0 but it would be better to revisit it to have a mixin that is guaranteed to work with all animations / transitions.gray-900for the gray saving button text.Testing Instructions
#1e1e1ehas now a sufficient color contrast with the gray colors used in the background gradient#fafafaand#e0e0e0.Testing Instructions for Keyboard
Screenshots or screencast