Add Unit testing for duotone enhanced pagination.

[cbravobernal]

What?

A follow up of #55415.
This PR adds automated testing to those previous PR changes.
I also added the test in the Core backport.
https://github.com/WordPress/wordpress-develop/pull/5540/files

Why?

To prevent unexpected crashes if duotone code changes.

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ phpunit/class-wp-duotone-test.php

[github-actions]

Flaky tests detected in 6003e20.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6613195641
📝 Reported issues:

• [Flaky Test] allows conversion back to blocks when the reusable block has unsaved edits #44601 in specs/editor/various/pattern-blocks.test.js
• [Flaky Test] can be inserted after refresh #55509 in specs/editor/various/pattern-blocks.test.js
• [Flaky Test] should be able to insert a reusable block twice #42758 in specs/editor/various/pattern-blocks.test.js
• [Flaky Test] will not break the editor if empty #49440 in specs/editor/various/pattern-blocks.test.js

[cbravobernal]

Closing this PR, as the test is already in Core.
WordPress/wordpress-develop#5561

[luisherranz]

Does Gutenberg run Core tests as well?

[cbravobernal]

As far as I remember, there are some people working on that. But it's not ready yet. Do you want to add them for future enhanced pagination features in Gutenberg?

[luisherranz]

I think we should have all the tests in Gutenberg as well, yes 🙂

[cbravobernal]

@luisherranz ready for review. It's the same code than Core.

[luisherranz]

Thanks, Carlos! 🎉

[getdave]

@c4rl0sbr4v0 Can I confirm that as per #55542 (comment) this does not require a backport for 6.5?

[cbravobernal]

Yep, this was committed long ago:
WordPress/wordpress-develop#5540 (comment)