Priority queue: request new idle callback for each item in queue #55529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -5 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 56b78d5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6593771554
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Something I noticed while investigating performance issues is that we call as many callbacks as possible if there is time remaining. The problem with that is that these selectors trigger React re-renders that are running in a micro task, which then prolongs the idle callback, blocking user interaction.
We’re calling way too many items from the queue without knowing how long they’ll take, because part of the work is done in micro tasks.
The easiest solution is to request an idle callback for every callback in the priority queue. If the browser is idle, these will be handled immediately, but when there's a user interaction they can be interrupted.
An alternative solution could be queueing a microtask, but the former seems easier.
See how the moment the micro tasks run, we are over time?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast