-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in FontCollection
#55439
Merged
Merged
Fix typo in FontCollection
#55439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
[Type] Bug
An existing feature does not function as intended
Internationalization (i18n)
Issues or PRs related to internationalization efforts
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
labels
Oct 18, 2023
Size Change: -1 B (0%) Total Size: 1.66 MB
ℹ️ View Unchanged
|
mukeshpanchal27
approved these changes
Oct 18, 2023
Related core ticket: https://core.trac.wordpress.org/ticket/59672 |
fabiankaegy
approved these changes
Oct 20, 2023
Are we going to cherry pick this one for 6.4RC2 or leave this for 6.5? |
swissspidy
removed
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Oct 20, 2023
Consensus on Slack was that we leave it to 6.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Internationalization (i18n)
Issues or PRs related to internationalization efforts
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reported by rabmalin on Slack: https://wordpress.slack.com/archives/C02RQBWTW/p1697622694628419
Not sure why this code is still in core given that the Font Library was punted to the next release 🤷
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast