Revert "Enable Block Renaming support for (almost) all blocks (#54426)" #55213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7aa5a91.
getdave
requested review from
spacedmonkey,
kevin940726,
Mamaduka,
ellatrix,
tellthemachines,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
getdave
added
the
[Type] Regression
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/blocks.php ❔ lib/experimental/blocks.php |
|
FWIW I personally don't mind "not reverting" and debugging the issue but if you think this gives you more time and confidence to debug at ease, it's ok as well. |
youknowriad
approved these changes
Oct 10, 2023
I don't have time to debug right now so yeh let's revert this and then we can investigate likely culprits. Nothing jumps out at me but then I've been starting at it a long time. |
|
I'm guessing it's the "renaming" hook itself that has some kind of issue and it was just made visible because it was enable in all blocks (especially paragraph) |
|
Size Change: +35 B (0%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
|
Closing in favour of #55250 |
auto-merge was automatically disabled
October 11, 2023 11:42
Pull request was closed
youknowriad
deleted the
revert/7aa5a913473c223402549a9060aafac652153965
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This reverts commit 7aa5a91.
Why?
Perf regression #54426 (comment)
How?
git revert 7aa5a913473c223402549a9060aafac652153965Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast