Handle calculateFrequency edge case #5507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Bug
Explicitly handle the case where `time` is undefined due to the user upgrading their version of Gutenberg.
aduth
force-pushed
the
fix/calculate-frecency
branch
from
a43d609 to
c01283c
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
calculateFrequencyto explicitly handle an edge case spotted by @aduth in #5342 (comment).The edge case is that
timewill beundefinedfor all blocks when a user first upgrades Gutenberg to the version that contains this new functionality.In this case, we'll simply assume that the block was used somewhere between a day and one week ago.