Performance Tests: Support the Site Editor's legacy spinner #54784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this selector, this locator resolves immediately because it doesn't find a spinner element.
|
ℹ️ Running Base branch validation in https://github.com/WordPress/gutenberg/actions/runs/6299641228 |
|
Size Change: -3 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Sep 25, 2023
|
@WunderBart, is there a reason performance tests don't output the failure errors? Currently, they're not visible in the CI logs. I came across a similar failure last week and had to make a "wild guess" to fix it 😅 |
Co-authored-by: Marin Atanasov <[email protected]>
@Mamaduka, yeah it's been on my radar for a while now but I still don't know why it suddenly stopped printing in CI. I did attempt to log everything out to see if the logs work at all and they do, so I assume it's something with the Anyway, if nothing's printed, you can also check the failures-artifacts.zip because you'll usually find a trace.zip there that you'll be able to view via https://trace.playwright.dev/. It's usually the fastest way of telling what's wrong with the test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is needed for older branches where the current
loaderelement is referred to asspinner. We need to be able to compare the current code to the older one (e.g. iframed vs legacy canvas) so some elements that are now legacy still need support in the performance tests.Without this selector, this locator resolves immediately because it doesn't find a spinner element. This can cause the consequent canvas body click to timeout (flaky). See the attached trace as an example (taken from a failed CI job):
👉 trace.zip (open via https://trace.playwright.dev/)