Patterns: Use modal for pattern duplication flow as workaround for changing sync status #54764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
|
Size Change: +940 B (0%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
1 task
Closed
aaronrobertshaw
force-pushed
the
update/pattern-duplication
branch
from
a04bad1 to
a362c82
Compare
|
@SaxonF if you have a moment to share your wisdom here, it would be greatly appreciated 🙏 What are your thoughts on this proof of concept that reuses the pattern creation modals for duplication? It facilitates the generally accepted workaround for not being able to change a pattern's sync status, i.e. duplicating/copying the pattern and setting a new sync status. This would come at the cost of a little extra friction if the user simply wants an exact duplicate. As it stands now on trunk, if you duplicate a pattern, it all happens immediately and you are taken to the new pattern's view page without the ability to change the sync status. |
|
Nice. I like it @aaronrobertshaw ! I think the added friction is fine. |
aaronrobertshaw
force-pushed
the
update/pattern-duplication
branch
from
a362c82 to
d191427
Compare
aaronrobertshaw
changed the title
kevin940726
reviewed
Oct 11, 2023
| sprintf( | ||
| // translators: %s: The new pattern's title e.g. 'Call to action (copy)'. | ||
| __( '"%s" duplicated.' ), | ||
| pattern.title |
There was a problem hiding this comment.
This shows the infamous [object object] in the snackbar as shown in the video too.
There was a problem hiding this comment.
Thanks, I completely missed that but just ran into it while adding the duplicate pattern command. I'll fix it up tomorrow (f3c2b9e)
|
This is testing well for me. The one thing I noticed is that when duplicating a theme pattern the categories get added with the lowercased name/slug instead of the label: 
|
kevin940726
approved these changes
Oct 11, 2023
packages/edit-site/src/components/create-template-part-modal/index.js
Outdated
Show resolved
Hide resolved
packages/edit-site/src/components/create-template-part-modal/index.js
Outdated
Show resolved
Hide resolved
Thanks for the suggested improvements @kevin940726 👍 I've pushed a commit addressing these. If you have the time to give this another quick sanity check, I'll then get it merged to unblock some additional pattern commands work. |
|
Flaky tests detected in 9609356. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6490049005
|
kevin940726
approved these changes
Oct 12, 2023
packages/edit-site/src/components/create-template-part-modal/index.js
Outdated
Show resolved
Hide resolved
This issue has been addressed via the refactor in #55292. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Why?
See #53320
TL;DR
How?
Testing Instructions
Screenshots or screencast
Screen.Recording.2023-09-24.at.5.46.04.pm.mp4