Default pattern terminology to Pattern instead of Block Pattern #54708
+105
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foosantos
requested review from
spacedmonkey,
kevin940726,
Mamaduka,
ellatrix,
ajitbohra,
nerrad,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @foosantos! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
richtabor
reviewed
Oct 5, 2023
richtabor
reviewed
Oct 5, 2023
foosantos
requested review from
dmsnell,
noahtallen,
ObliviousHarmony,
t-hamano,
fluiddot,
dcalhoun,
gziolo,
adamsilverstein,
talldan,
swissspidy,
peterwilsoncc and
anton-vlasenko
as code owners
foosantos
requested review from
ntwb,
luisherranz,
DAreRodz,
noisysocks,
draganescu,
tellthemachines,
adamziel,
getdave,
atimmer,
artemiomorales,
michalczaplinski,
ZebulanStanphill,
mmtr and
ajlende
as code owners
|
In order to merge this PR, could you rebase with the latest trunk just to be sure? If the GitHub Action fails, you'll probably need to fix that too. thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR replaces mentions of "Block Patterns" with "Patterns" only.
Fixes #49617.
Why?
There's an inconsistency in the labeling of the Patterns — sometimes it's "Pattern" while sometimes it's "Block Patterns" — and the goal would be to fix that.
How?
I mostly searched for the mentions of "Block Patterns" and replaced them manually based on the context.
Testing Instructions
Basically, a good step would be to search for mentions of patterns in the code and see if makes sense for these contexts.