Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Remove outdated info #54707

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Docs: Remove outdated info #54707

merged 2 commits into from
Sep 26, 2023

Conversation

brookewp
Copy link
Contributor

What?

Tooltip no longer uses our Popover component since the refactor in #48440, so this removes the info on our legacy tooltip in the Popover section of the components package README.

@brookewp brookewp added [Type] Developer Documentation Documentation for developers [Package] Components /packages/components labels Sep 21, 2023
@brookewp brookewp requested a review from ajitbohra as a code owner September 21, 2023 23:45
@github-actions
Copy link

Flaky tests detected in c7408ccb415e42f74d002ef422c81f5ad386a44b.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6268257937
📝 Reported issues:

ciampo
ciampo reviewed Sep 22, 2023
View reviewed changes
packages/components/README.md Outdated

_If you're using [`Popover`](/packages/components/src/popover/README.md) or [`Tooltip`](/packages/components/src/tooltip/README.md) components outside of the editor, make sure they are rendered within a `SlotFillProvider` and with a `Popover.Slot` somewhere up the element tree._
_If you're using [`Popover`](/packages/components/src/popover/README.md) outside of the editor, make sure they are rendered within a `SlotFillProvider` and with a `Popover.Slot` somewhere up the element tree._
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this paragraph can also be removed, after @youknowriad's recent Popover updates (for reference:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Riad, I guess this paragraph is out of date and can be deleted?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's out of date. The Provider is no longer mandatory but you can still use it with the Slot if you want to control the exact position of the popover.

chad1008
chad1008 approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@chad1008 chad1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, pending the change to the paragraph @ciampo mentioned. Approving so you can merge after updating that bit 😄

@brookewp brookewp force-pushed the update/components-readme branch from c7408cc to 9230084 Compare September 25, 2023 23:19
@ciampo ciampo enabled auto-merge (squash) September 26, 2023 12:53
@ciampo
Copy link
Contributor

ciampo commented Sep 26, 2023

@brookewp not sure what's going on with CI checks. You may want to merge latest trunk again and see if tests pass

@brookewp brookewp force-pushed the update/components-readme branch from 9230084 to 78e81c1 Compare September 26, 2023 20:16
@ciampo ciampo merged commit be69ef4 into trunk Sep 26, 2023
49 of 50 checks passed
@ciampo ciampo deleted the update/components-readme branch September 26, 2023 21:03
@github-actions github-actions bot added this to the Gutenberg 16.8 milestone Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciampo ciampo ciampo left review comments

@youknowriad youknowriad youknowriad left review comments

@chad1008 chad1008 chad1008 approved these changes

@tyxla tyxla Awaiting requested review from tyxla

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees
No one assigned
Labels
[Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 16.8
Development

Successfully merging this pull request may close these issues.
4 participants
@brookewp @ciampo @youknowriad @chad1008