Patterns: Add editing of pattern categories to site editor #54640
+317
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Enhancement
glendaviesnz
commented
Sep 20, 2023
| ); | ||
| }; | ||
|
|
||
| export default function PatternCategories( { post } ) { |
There was a problem hiding this comment.
this involved a bit of copying from the editor package because of the different way we are handling editing posts in the site editor, it would be nice to reduce the duplication at some point but I think this would be better handled post 6.4 - I think this small amount of copy paste is ok in the meantime.
There was a problem hiding this comment.
Sounds good, perhaps we should create an issue to follow up on this so it doesn't slip through the cracks.
|
Size Change: +961 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
It will be good to get this one into 6.4 as the re-categorization of patterns was pretty awkward having to leave the site editor to edit the pattern via the post type editor.
The PR tests well. The only thing that caught me out was not tokenizing the incomplete tokens in the category field as we do in the pattern creation modal.
I'm not sure if we should be consistent with the pattern creation modal or the normal post-type category field. For the site editor, I'd probably lean towards the modal but it can be a follow-up.
The fit in the sidebar was a little clunky but I found that was due to the revisions rendering an empty row. I pushed a commit that cleans up that one. So given that, it might be better to get a fresh set of eyes to give a final review on this PR.
| Before | After |
|---|---|
 |
 |
| @@ -64,6 +70,7 @@ export default function TemplatePanel() { | |||
| > | |||
| <LastRevision /> | |||
| </PanelRow> | |||
| { postType === 'wp_block' && <PatternCategories post={ record } /> } | |||
There was a problem hiding this comment.
Should we be using the recently consolidated constants here and in other places instead of 'wp_block'?
There was a problem hiding this comment.
If desired, perhaps it could be included in a code quality follow-up as suggested for refactoring the PatternCategories component.
There was a problem hiding this comment.
Have switched to the constant.
| ); | ||
| }; | ||
|
|
||
| export default function PatternCategories( { post } ) { |
There was a problem hiding this comment.
Sounds good, perhaps we should create an issue to follow up on this so it doesn't slip through the cracks.
I have switched it to tokenize on blur to match the modal. |
kevin940726
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
For future reference, this file is largely copied/based on https://github.com/WordPress/gutenberg/blob/08b6f1c0a887eeebaf203bbf7a3f96cedd3b618c/packages/editor/src/components/post-taxonomies/flat-term-selector.js.
There was a problem hiding this comment.
Thanks for adding the link. The copy pasta was flagged earlier with the possibility of a dedicated follow-up issue discussed.
packages/edit-site/src/components/sidebar-edit-mode/template-panel/index.js
Show resolved
Hide resolved
aaronrobertshaw
deleted the
update/site-editor-add-pattern-category-edit
branch
9 tasks
This was referenced Oct 11, 2023
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds the ability to edit categories to the site editor pattern editor.
Why?
Currently there is no way to edit the categories of a pattern in the site editor.
How?
Adds a category editing row to the right panel of the pattern editor page.
Testing Instructions
Screenshots or screencast
site-edit-patternb-cats.mp4