Block Editor: Memoize the createPageEntity callback #54580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…firing on every keystroke
|
Size Change: +13 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
kevin940726
approved these changes
Sep 19, 2023
Good question - my VS Code linter highlighted the issue. |
glendaviesnz
deleted the
fix/block-editor-settings-performance-issue
branch
|
Thanks for the quick fix 👍 |
mikachan
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Memoizes the createPageEntity callback in the useBlockEditorSettings hook.
Why?
Because a new function is generated with every call currently the useBlockEditorSettings useMemo return hook is being rerun with every keystroke in the block editor.
How?
Wraps the function in a
useCallback.Testing Instructions
Create pageoption that appears in dropdownScreenshots or screencast
newpage.mp4