Query Loop: Update modal role and focus first element #54507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAreRodz
added
[Type] Enhancement
|
@jeryj, @alexstine, I've added you as reviewers as this is accessibility-related. Let me know if this change is OK or if there's a better way to handle the modal. Thanks! 😊 |
DAreRodz
added
[Focus] Accessibility (a11y)
|
Size Change: +21 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ad90d7c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6199960019
|
24 tasks
|
Still not entirely sure how to test this? |
Could you expand on this testing instruction? I've been adding blocks inside the Query Loop but not one that will trigger the modal to pop up. Can you recommend some specific blocks for us to add, and where to add them within the Query Loop? |
Oh, sure! @alexstine, @jeryj, sorry for the confusion; I didn't know what name to use. 😅 By any plugin block I meant any third-party block, i.e., those not bundled in WordPress or Gutenberg, installed from the Block Directory. Any of them should make the modal appear. EDIT: I've updated the testing instructions. |
luisherranz
approved these changes
Oct 25, 2023
luisherranz
deleted the
update/query-loop-enhanced-pagination-modal-a11y-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Makes the "Enhanced pagination will be disabled" modal to be announced by screen readers, also focusing the "OK" button.
Suggested by @SantosGuillamot.
Why?
To improve accesibility.
How?
Adding the following properties to the
Modalcomponent.Testing Instructions