Patterns: Update pattern inserter to show all categories regardless of sync status #54480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lts if no patterns for category sync type combination
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
|
Size Change: +158 B (0%) Total Size: 1.53 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Thanks for iterating here @glendaviesnz 👍
After getting to play with the new UX it definitely feels better to me. I suspect we can improve the "no results" states in time but for now communicate things well.
While testing I noticed some weird behaviour that we might want to dig into before landing the overall feature.
If you select a sync type filter and navigate to a pattern where there are no results, wait a little while, then the panel suddenly updates to the "All" sync type option without any interaction from the user.
The time for this to happen appeared to vary as well and occurred regardless of whether the sync filter was for synced or unsynced patterns. It also exists in both the inserter panel and the pattern explorer.
Screen.Recording.2023-09-15.at.11.43.51.am.mp4
Screen.Recording.2023-09-15.at.11.41.40.am.mp4
This should be fixed now @aaronrobertshaw |
aaronrobertshaw
approved these changes
Sep 15, 2023
packages/block-editor/src/components/inserter/block-patterns-tab.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Aaron Robertshaw <[email protected]>
glendaviesnz
merged this pull request
into
add/pattern-category-ui
42 of 45 checks passed
glendaviesnz
added a commit
that referenced
this pull request
Sep 15, 2023
…f sync status (#54480) Co-authored-by: Aaron Robertshaw <[email protected]>
|
Flaky tests detected in 51a0770. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6193919652
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the sync type filter from the category list generation.
Why?
Currently in #53835 when the pattern sync status filter is changed the category list changes to show only the categories that have patterns of that sync status. This was to avoid showing categories that were in fact empty as generally only populated categories display, but it complicates the code, and the UX is a little odd in the way the sync filter in one panel affects categories in another.
How?
Removes the plumbing that was passing the sync status back through to the category hook, and also made sure 0 resutls messages were showing.
Testing Instructions
Screenshots or screencast
patterns-sync-fix.mp4