Remove Tooltip workarounds added in the site and block editor #54450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brookewp
added
[Type] Enhancement
|
Size Change: -64 B (0%) Total Size: 1.53 MB
ℹ️ View Unchanged
|
brookewp
force-pushed
the
remove/tooltip-icon-workarounds
branch
from
fb5d3c4
to
58e7d2e
Compare
|
It appears this PR introduced a bug where the site editor's pattern page now throws a console error as reported in #53835 (comment). Testing the commit prior to this show no error. |
I fixed the warning in #54492. It changes |
|
Thank you @aaronrobertshaw for sharing, and @kevin940726 for creating a fix. Much appreciated! 🙇♀️ |
bph
added
[Type] Code Quality
mikachan
added
the
[Feature] Site Editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The recent update to Tooltip (#48222) fixed a bug where an
<Icon>component could not be rendered as a child (#43129). A wrapper was added as a workaround, and in some cases, additional CSS.There was also a wrapper around a
<Button>with a to-do note to remove after merging #44198, so I included that as well.Why?
To clean up what is now unnecessary wrappers and CSS. Also, to highlight that this workaround is no longer needed.
How?
Removing the wrapper and unnecessary CSS, if any.
Testing Instructions
All of these changes can be tested in the Site Editor:
Patterns
Editor (using Group block)