Update/form token field onblur #54445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Package] Components
|
Size Change: +27 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8cb9edb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6178239193
|
glendaviesnz
force-pushed
the
add/pattern-category-ui
branch
from
e291597
to
81876cd
Compare
glendaviesnz
requested review from
spacedmonkey,
nerrad,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
glendaviesnz
force-pushed
the
add/pattern-category-ui
branch
from
b41360a
to
85f4c5e
Compare
glendaviesnz
force-pushed
the
update/form-token-field-onblur
branch
from
8cb9edb
to
d408594
Compare
|
@aaronrobertshaw, @kevin940726 now that the main category PR is merged I have rebased this against trunk - it was all tested and approved here, but backed that out as this is better as single commit into trunk - so could do with a quick retest before merging into trunk when yo have time. |
aaronrobertshaw
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Thanks for splitting this one out on its own @glendaviesnz 👍
LGTM!
✅ Has changelog
✅ Unit tests pass
✅ Component behaves as advertised in Storybook examples
✅ Test well in the post editor
ciampo
added
the
has dev note
|
Added a dev note in the PR description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a
tokenizeOnBlurprop. This is a copy of #53976 as merging that into the feature branch was not the best approach, so reverted that and will rebase this against trunk and merge into trunk separately once the rest of the pattern category feature is merged.Why?
To allow consuming components to specify that any
incompleteTokenValueis saved when the field loses focus. The main purpose for this is to prevent users saving the new add patterns model with unsaved categories added.How?
If
tokenizeOnBluristruethenaddNewTokenis run inonBlurTesting Instructions
Create patternmenu option'click outside the box so it loses focusScreenshots or screencast
Before:
form-token-before.mp4
After:
form-token-after.mp4
✍️ Dev note
A new
tokenizeOnBlurprop has been added toFormTokenField, causing the component to tokenize its current input instead of discarding it when losing focus.This is particularly useful when
FormTokenFieldis used in places like modals, where the user may press a button causing the modal to close andFormTokenFieldto lose focus before its input could be tokenized.