Adjust input-style__focus mixin to proper focus size #54398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Bug
|
Size Change: +10 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
Curious how this has been wrong for so long, I could swear it was the correct 1.5px initially. In fact in testing this PR I looked at a variety of different inputs to test this is correct, but it seems to be!
The reason it's working is that the .5px shadow is applied on top of a 1px border:
Let's land this, but perhaps add a CSS comment right above? Something like:
// Expand the default border focus style by .5px to be a total of 1.5px.
|
Question, can we simply add the border-color-change to the mixin, to make it more explicit? Something like ? |
I'm not following? The |
Added, good call. |
|
Flaky tests detected in 33788b2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6175023668
|
richtabor
force-pushed
the
fix/input-style-focus-mixin
branch
from
13832bc
to
33788b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Small style adjustment to make focus consistent across components. These two use the
@input-style__focusmixin, which was adding too large of a focus shadow; I used the same technique used elsewhere — and recently in #54394.Why?
Consistency.
Testing Instructions
Screenshots or screencast