Tooltip: render tooltip markup in the DOM only when open #54312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Regression
|
I'm not entirely certain I'm interpreting the performance results accurately, but it seems this gets the job done! 👍🏽 It's worth mentioning that the |
ciampo
requested review from
youknowriad,
diegohaz,
tyxla,
chad1008 and
brookewp
|
Size Change: +2 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6f8310e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6130467057
|
|
For ease of reading: Performance check results from #48440 , where the regression was introducedLatest performance check results from this PR (numbers are back to pre- #48440 levels) |
ciampo
changed the title
|
Thanks for the fix here and the suggestion @diegohaz ❤️ |
brookewp
added a commit
that referenced
this pull request
Sep 12, 2023
brookewp
added a commit
that referenced
this pull request
Sep 12, 2023
* Button: Update test assertion to match test name * Restore replaced assertion for button * Update assertions after changes to tooltip in #54312
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As per #48440 (comment), PR #48440 introduced a regression in rendering performance.
This PR experiments with rendering the
Tooltipdynamically, in case this can help improving the rendering performance again.How?
Using the
openstate from the Ariakit store to effectively render (or not) the tooltip in the DOM.Unit tests were updated as necessary to reflect the fact that, when the tooltip isn't "open", tooltip-related markup is not rendered in the DOM. Changes to unit tests are mostly un-doing changes from #48440, including the ones to
LinkControlTesting Instructions