Patterns: merge unsynced into inserter patterns tab and add paging and filtering #54007
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| /** | ||
| * WordPress dependencies | ||
| */ | ||
| import { | ||
| __experimentalVStack as VStack, | ||
| __experimentalHStack as HStack, | ||
| __experimentalText as Text, | ||
| Button, | ||
| } from '@wordpress/components'; | ||
| import { __, _x, _n, sprintf } from '@wordpress/i18n'; | ||
|
|
||
| export default function Pagination( { | ||
| currentPage, | ||
| numPages, | ||
| changePage, | ||
| totalItems, | ||
| } ) { | ||
| return ( | ||
| <VStack> | ||
| <Text variant="muted"> | ||
| { | ||
| // translators: %s: Total number of patterns. | ||
| sprintf( | ||
| // translators: %s: Total number of patterns. | ||
| _n( '%s item', '%s items', totalItems ), | ||
| totalItems | ||
| ) | ||
| } | ||
| </Text> | ||
| <HStack | ||
| expanded={ false } | ||
| spacing={ 3 } | ||
| justify="flex-start" | ||
| className="block-editor-patterns__grid-pagination" | ||
| > | ||
| <HStack expanded={ false } spacing={ 1 }> | ||
| <Button | ||
| variant="tertiary" | ||
| onClick={ () => changePage( 1 ) } | ||
| disabled={ currentPage === 1 } | ||
|
There was a problem hiding this comment. I wonder where we should move the focus after navigating to a different page. Should we retain the focus on the prev/next button? Or should we move the focus to the first pattern to match the visual jump? If we decide to retain the focus then we probably want to change this to There was a problem hiding this comment. I think it would be good to look at this as a follow-up combined with the site editor pagination - ideally we should finalise the |
||
| aria-label={ __( 'First page' ) } | ||
| > | ||
| « | ||
| </Button> | ||
| <Button | ||
| variant="tertiary" | ||
| onClick={ () => changePage( currentPage - 1 ) } | ||
| disabled={ currentPage === 1 } | ||
| aria-label={ __( 'Previous page' ) } | ||
| > | ||
| ‹ | ||
| </Button> | ||
| </HStack> | ||
| <Text variant="muted"> | ||
| { sprintf( | ||
| // translators: %1$s: Current page number, %2$s: Total number of pages. | ||
| _x( '%1$s of %2$s', 'paging' ), | ||
| currentPage, | ||
| numPages | ||
| ) } | ||
| </Text> | ||
| <HStack expanded={ false } spacing={ 1 }> | ||
| <Button | ||
| variant="tertiary" | ||
| onClick={ () => changePage( currentPage + 1 ) } | ||
| disabled={ currentPage === numPages } | ||
| aria-label={ __( 'Next page' ) } | ||
| > | ||
| › | ||
| </Button> | ||
| <Button | ||
| variant="tertiary" | ||
| onClick={ () => changePage( numPages ) } | ||
| disabled={ currentPage === numPages } | ||
| aria-label={ __( 'Last page' ) } | ||
| > | ||
| » | ||
| </Button> | ||
| </HStack> | ||
| </HStack> | ||
| </VStack> | ||
| ); | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| .block-editor-patterns__grid-pagination { | ||
| border-top: 1px solid $gray-800; | ||
| padding: $grid-unit-05; | ||
|
|
||
| .components-button.is-tertiary { | ||
| width: $button-size-compact; | ||
| height: $button-size-compact; | ||
| justify-content: center; | ||
|
|
||
| &:disabled { | ||
| color: $gray-600; | ||
| background: none; | ||
| } | ||
|
|
||
| &:hover:not(:disabled) { | ||
| background-color: $gray-700; | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This icon is not tabbable and thus won't announce this text for screen readers. Maybe we should merge this into the description above? (And yep probably it's also an issue in the patterns page in the site editor? 😅 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it would be more annoying than useful to hit that for every pattern, especially if tabbing through a filtered list of just synced patterns? Do you think we could look at this as a follow up and cover site editor and post inserter together?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I meant as a follow-up to look into in the future!