PaletteEdit: Fix component height #54000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walbo
added
[Type] Bug
|
Size Change: -17 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See #49041
Fixes
PaletteEditheight, both in the editor and in the storybook.Why?
The component has less padding below the input field (1px) in the block editor, and in the storybook at was way to heigh. This PR fixes so the padding issue and so the height doesn't depend on style only present in the block editor.
How?
Remove the height from the container. The elements inside the container is styled to have the same height so the container doesn't need it. (Alternative approach would be to set correct height on the container and add boxSizing).
Testing Instructions
Screenshots or screencast
Editor
Storybook