Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 'nofollow' setting to inline links (rich text only) #53945

Merged
merged 12 commits into from
Aug 31, 2023
+121 −9
Merged

Adds 'nofollow' setting to inline links (rich text only) #53945

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b0bc5db
Add ability for inline link format to parse and handle rel no follow
getdave Aug 25, 2023
9945316
Add no follow to Link Control
getdave Aug 25, 2023
87c8ce8
Add support for optional help text on setting controls
getdave Aug 25, 2023
a7a5bda
Only apply new setting to inline links for now
getdave Aug 25, 2023
c9b2a6b
Expose default link settings for use by component consumers
getdave Aug 25, 2023
d3c1449
Extend default settings in inline link implementation
getdave Aug 25, 2023
db72d42
Use nofollow lowercase
getdave Aug 25, 2023
cf2015f
Make help text the title
getdave Aug 25, 2023
ab7d7f9
Adds test coverage
getdave Aug 25, 2023
6955878
Use help text to reduce size of label
getdave Aug 25, 2023
ed90bf7
Correct text to qualify statement
getdave Aug 25, 2023
ab5a41c
Remove help text
getdave Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Extend default settings in inline link implementation
  • Loading branch information
@getdave
getdave committed Aug 31, 2023
commit d3c1449f7e0ed1485c7bcf2325524317beaf2004
5 changes: 1 addition & 4 deletions packages/format-library/src/link/inline.js
View file
Original file line number Diff line number Diff line change
@@ -32,10 +32,7 @@ import { link as settings } from './index';
import useLinkInstanceKey from './use-link-instance-key';

const LINK_SETTINGS = [
{
id: 'opensInNewTab',
title: __( 'Open in new tab' ),
},
...LinkControl.DEFAULT_LINK_SETTINGS,
{
id: 'noFollow',
title: __( 'No follow' ),