Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProgressBar: Add transition to determinate indicator #53877

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Aug 22, 2023

What?

This PR adds a transition to the progress bar indicator when in determinate mode.

Suggested by @jasmussen and @mtias here.

Why?

To make the progress bar feel smoother to the end user. Here's some additional rationale: #53399 (comment)

How?

We're just adding a width transition for the determinate mode only. The indeterminate one doesn't need it, because the indicator there keeps a constant width.

Testing Instructions

Testing Instructions for Keyboard

None

Screenshots or screencast

Before:

Screen.Recording.2023-08-22.at.19.24.21.mov

After:

Screen.Recording.2023-08-22.at.19.23.22.mov

@tyxla tyxla added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Package] Components /packages/components labels Aug 22, 2023
@tyxla tyxla requested a review from ajitbohra as a code owner August 22, 2023 16:26
@tyxla tyxla self-assigned this Aug 22, 2023
@tyxla tyxla force-pushed the add/progress-bar-indicator-transition branch from 862afce to d29e4b7 Compare August 22, 2023 16:32
@github-actions
Copy link

github-actions bot commented Aug 22, 2023

Flaky tests detected in d29e4b7.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5941554375
📝 Reported issues:

Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think you can actually make the transition even slower. Maybe try 0.4ms? But this feels solid to me!

@tyxla
Copy link
Member Author

tyxla commented Aug 23, 2023

Nice! I think you can actually make the transition even slower. Maybe try 0.4ms? But this feels solid to me!

Thanks for taking a look! I think 0.4 looks better:

Screen.Recording.2023-08-23.at.12.53.01.mov

@tyxla tyxla removed the Needs Design Feedback Needs general design feedback. label Aug 23, 2023
@jasmussen
Copy link
Contributor

I agree, that's very nice.

@tyxla tyxla merged commit f5a26db into trunk Aug 23, 2023
@tyxla tyxla deleted the add/progress-bar-indicator-transition branch August 23, 2023 10:47
@github-actions github-actions bot added this to the Gutenberg 16.6 milestone Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

2 participants