ProgressBar
: Add transition to determinate indicator
#53877
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds a transition to the progress bar indicator when in determinate mode.
Suggested by @jasmussen and @mtias here.
Why?
To make the progress bar feel smoother to the end user. Here's some additional rationale: #53399 (comment)
How?
We're just adding a
width
transition for the determinate mode only. The indeterminate one doesn't need it, because the indicator there keeps a constant width.Testing Instructions
npm run storybook:dev
ProgressBar
component: http://localhost:50240/?path=/docs/components-experimental-progressbar--docsvalue
field and witness how the indicator animates when transitioning.Testing Instructions for Keyboard
None
Screenshots or screencast
Before:
Screen.Recording.2023-08-22.at.19.24.21.mov
After:
Screen.Recording.2023-08-22.at.19.23.22.mov