AlignmentMatrixControl: replace act() with userEvent
#53703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brookewp
added
[Type] Enhancement
tyxla
approved these changes
Aug 16, 2023
| await act( () => getCell( alignment ).focus() ); | ||
| await user.click( getCell( alignment ) ); | ||
|
|
||
| expect( getCell( alignment ) ).toHaveFocus(); |
There was a problem hiding this comment.
Replacing a .focus() with a .click() makes the intention a bit less clear, but the "have focus" assertion definitely helps clarify it, so thanks for adding that assertion 👍
There was a problem hiding this comment.
Thank you for sharing! It's helpful to know it was a useful addition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update test to utilize
userEventand removeact().Why?
While working on #48222, I came across this test which was failing due to
...wrapped into act(...)errors.How?
Removed
act()and addeduserEvent.click. This moves the test closer to how a user would interact viaclickinstead of setting the focus. I've added another assertion to check the element has focus after the click, instead.Testing Instructions
Verify tests still pass:
packages/components/src/alignment-matrix-control/test/index.tsx