-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESLint: Fix all storybook/prefer-pascal-case
warnings
#53683
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Package] Components
/packages/components
[Package] Block editor
/packages/block-editor
Storybook
Storybook and its stories for components
labels
Aug 15, 2023
Size Change: 0 B Total Size: 1.51 MB ℹ️ View Unchanged
|
Flaky tests detected in 39ad2a8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5868044975
|
Mamaduka
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Block editor
/packages/block-editor
[Package] Components
/packages/components
Storybook
Storybook and its stories for components
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes all existing
storybook/prefer-pascal-case
ESLint warnings. See this for more info about the rule.Why?
Ideally, we should have zero warnings in the codebase.
How?
We're just altering the stories to be capitalized.
Testing Instructions
Inserter
BoxControl
ConfirmDialog
Navigation
RadioGroup
SlotFill
Text
Testing Instructions for Keyboard
None
Screenshots or screencast
None