Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnotes: fix accidental override #53663

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Footnotes: fix accidental override #53663

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e92a5f0
Footnotes: fix accidental override
ellatrix Aug 15, 2023
490bee0
Remove double quotes
ellatrix Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/block-library/src/footnotes/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,9 +160,8 @@ function wp_add_footnotes_revisions_to_post_meta( $post ) {
}
}

foreach ( array( 'post', 'page' ) as $post_type ) {
add_action( "rest_after_insert_{$post_type}", 'wp_add_footnotes_revisions_to_post_meta' );
}
add_action( 'rest_after_insert_post', 'wp_add_footnotes_revisions_to_post_meta' );
add_action( 'rest_after_insert_page', 'wp_add_footnotes_revisions_to_post_meta' );
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting that we could move this to the register_block_core_footnotes function, which runs on init, but I'm scared to move code around at this point. It's an option though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We anyway went for hardcoding these for this release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now; it'll have to change anyway once we add support for other post types so we can leave bigger changes till then 😄


/**
* Restores the footnotes meta value from the revision.
Expand Down