-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E Storybook: Fix for Storybook v7 #53658
Conversation
Size Change: 0 B Total Size: 1.5 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well for me! The build errors in trunk are no longer present, and it spins up E2E Storybook in the browser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 I have confirmed the following on both Windows host OS and WSL2 (Ubuntu):
- ✅ In trunk, the process exits with code1
- ✅ In this PR, the command is executed successfully and Storybook is started
What?
Fixes the setup for the components e2e test Storybook to work with our recent upgrade to Storybook v7 (#53520).
How?
docs
setting because it's erroring and we don't need it here.Testing Instructions
npm run storybook:e2e:dev
should spin up the E2E Storybook in the browser without errors.