Skip migration logs in the Patterns screen #53626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Enhancement
|
Size Change: +13 B (0%) Total Size: 1.5 MB
ℹ️ View Unchanged
|
glendaviesnz
approved these changes
Aug 14, 2023
aaronrobertshaw
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Thanks for cleaning this up @kevin940726
✅ Changes look good
✅ All locations where blocks are parsed for the patterns page in the site editor are covered
✅ Migration logs are skipped matching inserter
✅ Tested with multiple older themes
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A small fix to skip migration logs in the Patterns screen.
Why?
It's annoying to developers when we're parsing all the available patterns and showing migration logs for each of them.
How?
Use the unstable
__unstableSkipMigrationLogsargument in theparsefunction. It's also used in where we load patterns in the inserter.gutenberg/packages/block-editor/src/store/selectors.js
Line 2326 in 26cf1f8
Testing Instructions
Testing Instructions for Keyboard
Same as above.
Screenshots or screencast
N/A