Webkit e2e: attempt to fix shift+click test #53564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.5 MB ℹ️ View Unchanged
|
|
Passed the first time and I don't see any reports of re-runs. Let's run it again. |
|
Again passes, don't see any sign of reattempts in the logs. Let's re-run a final time. |
|
Passed again. Let's merge this so we don't annoy people further. |
|
@ellatrix, this e2e test is very much still flaky. It fails at least a few times a day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Tries to fix #53524.
Let's see if removing the force option work, and making sure the coordinates are within the bold tag.
I'll re-run the jobs a couple of times.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast