Site Editor: Fix BlockPreview in Template panel when editing a page #53550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Bug
|
Size Change: +36 B (0%) Total Size: 1.5 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
Thanks for the quick fix @noisysocks 🚀
✅ Could replicate original issue
✅ Preview displays correctly after applying this PR
✅ Follows same approach as #52899
✅ Feature's updated e2e spec passes locally (GitHub is still running)
LGTM!
| Before | After |
|---|---|
 |
 |
|
Flaky tests detected in 14273ec. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5827886985
|
youknowriad
reviewed
Aug 11, 2023
| @@ -34,7 +35,7 @@ export default function EditTemplate() { | |||
| queryArgs | |||
| ), | |||
| title: template?.title, | |||
| blocks: template?.blocks, | |||
| content: template?.content, | |||
There was a problem hiding this comment.
I think we should retrieve both blocks and content and prefer blocks if defined otherwise, you'll get an outdated preview.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the
BlockPreviewthat appears in the sidebar's Template panel when editing a page in the site editor.Why?
It went missing as a result of #52417 removing the
blocksattribute from the object retuned bygetEditedEntityRecord.How?
The fix is identical to #52899. We simply
parse()contentourselves.Testing Instructions
I added a regression assertion to this feature's E2E spec.
To test manually:
Screenshots or screencast