-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deepsignal version #53549
Update deepsignal version #53549
Conversation
Size Change: -1 B (0%) Total Size: 1.5 MB
ℹ️ View Unchanged
|
Gutenberg works now with npm 8, but enforces legacy peer deps. That means you will most likely need to explicitly list these peer dependencies, unless they come from a different package. Once we switch to the new behavior for peer deeps, then all of them will get installed automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Thanks for the PR, Noah!
do we need to add any of the other peer dependencies to the interactivity package besides
@preact/signals
andpreact
?
No, those are the correct ones for Gutenberg 🙂
When should we use it instead of the |
This PR doesn't impact the feature at all so it |
Ok, thanks Greg! |
What?
This updates the deepsignal version in Gutenberg, which fixes a peer dependency warning which happened in an older version of the package.
@luisherranz do we need to add any of the other peer dependencies to the interactivity package besides
@preact/signals
andpreact
?Why?
See luisherranz/deepsignal#39