Conditionally render Link UI settings drawer wrapper only when multiple settings are present #53531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Enhancement
|
@richtabor @scruffian The tests will need updating to cater for this, so I would appreciate a confidence check here before I put in the additional effort there 🙇 |
getdave
changed the title
8 tasks
|
Size Change: -239 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
What's the best way to test it with additional settings? |
getdave
force-pushed
the
try/link-ui-only-use-advanced-drawer-for-multiple-settings
branch
from
1ce90fd to
90a0ffe
Compare
|
Flaky tests detected in c7eb6d1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5869273824
|
|
@richtabor I don't see much value in pursuing this PR until we add more controls in WP Core. I can't even e2e test it as things stand because one of the tests no longer makes sense. I think this should be paused for now. |
|
I'm not planning to progress this one. We can pick it up if it ever becomes a concern again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Only renders the "Advanced" area when there is more than a single setting in the Link Control component.
Applies some feedback from #52799.
Why?
The toggle was added to help clean up the UI in anticipation of allowing the ability to add more settings in the future. However, currently most implementations (including Core) only have a single setting
Opens in new tab. It seems a little redundant to have a drawer when there is only a single setting.How?
Conditionally only renders the
Advancedsettings toggle is there is more than a single setting. Otherwise just renders directly under the inputs.Testing Instructions
Opens in new tabcheckboxAdvancedtoggleOpens in new tabbehaves as expected.Testing Instructions for Keyboard
Screenshots or screencast