Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing flow: add multi select e2e for firefox and webkit #53513

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Writing flow: add multi select e2e for firefox and webkit #53513

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e68a3d
Writing flow: add multi select e2e for firefox and webkit
ellatrix Aug 10, 2023
2671891
Skip some in ff
ellatrix Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 37 additions & 9 deletions test/e2e/specs/editor/various/multi-block-selection.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const { test, expect } = require( '@wordpress/e2e-test-utils-playwright' );
* Some tests in this file use the character `|` to represent the caret's position
* in a more readable format.
*/
test.describe( 'Multi-block selection', () => {
test.describe( 'Multi-block selection (@firefox, @webkit)', () => {
test.use( {
multiBlockSelectionUtils: async ( { page, editor }, use ) => {
await use( new MultiBlockSelectionUtils( { page, editor } ) );
Expand Down Expand Up @@ -48,7 +48,7 @@ test.describe( 'Multi-block selection', () => {
} );

// See #14448: an incorrect buffer may trigger multi-selection too soon.
test( 'should only trigger multi-selection when at the end', async ( {
test( 'should only trigger multi-selection when at the end (-webkit)', async ( {
page,
editor,
pageUtils,
Expand Down Expand Up @@ -286,7 +286,7 @@ test.describe( 'Multi-block selection', () => {
} );

// @see https://github.com/WordPress/gutenberg/issues/34118
test( 'should properly select a single block even if `shift` was held for the selection', async ( {
test( 'should properly select a single block even if `shift` was held for the selection (-firefox)', async ( {
page,
editor,
pageUtils,
Expand Down Expand Up @@ -318,7 +318,7 @@ test.describe( 'Multi-block selection', () => {
] );
} );

test( 'should properly select multiple blocks if selected nested blocks belong to different parent', async ( {
test( 'should properly select multiple blocks if selected nested blocks belong to different parent (-webkit)', async ( {
editor,
multiBlockSelectionUtils,
} ) => {
Expand Down Expand Up @@ -352,7 +352,7 @@ test.describe( 'Multi-block selection', () => {
.toEqual( [ 1, 4 ] );
} );

test( 'should properly select part of nested rich text block while holding shift', async ( {
test( 'should properly select part of nested rich text block while holding shift (-firefox)', async ( {
page,
editor,
} ) => {
Expand Down Expand Up @@ -614,7 +614,7 @@ test.describe( 'Multi-block selection', () => {
] );
} );

test( 'should keep correct selection when dragging outside block', async ( {
test( 'should keep correct selection when dragging outside block (-firefox)', async ( {
page,
editor,
} ) => {
Expand Down Expand Up @@ -730,7 +730,7 @@ test.describe( 'Multi-block selection', () => {
] );
} );

test( 'should clear selection when clicking next to blocks', async ( {
test( 'should clear selection when clicking next to blocks (-firefox)', async ( {
page,
editor,
multiBlockSelectionUtils,
Expand Down Expand Up @@ -1113,7 +1113,7 @@ test.describe( 'Multi-block selection', () => {
] );
} );

test( 'should write over selection', async ( {
test( 'should write over selection (-firefox)', async ( {
page,
editor,
pageUtils,
Expand All @@ -1138,6 +1138,34 @@ test.describe( 'Multi-block selection', () => {
] );
} );

test( 'should write over selection (-chromium, -webkit, @firefox)', async ( {
page,
editor,
pageUtils,
} ) => {
await editor.canvas
.getByRole( 'button', { name: 'Add default block' } )
.click();
await page.keyboard.type( '1[' );
await page.keyboard.press( 'Enter' );
await page.keyboard.type( ']2' );
await page.keyboard.press( 'ArrowLeft' );
// Select everything between [].
await pageUtils.pressKeys( 'Shift+ArrowLeft', { times: 3 } );

// Ensure selection is in the correct place.
await page.keyboard.type( '|' );
// For some reason, this works completely fine when testing manually in
// Firefox, but with Playwright it only merges the blocks but doesn't
// insert the character.
await expect.poll( editor.getBlocks ).toMatchObject( [
{
name: 'core/paragraph',
attributes: { content: '12' },
},
] );
} );

test( 'should handle Enter across blocks', async ( {
page,
editor,
Expand Down Expand Up @@ -1213,7 +1241,7 @@ test.describe( 'Multi-block selection', () => {
] );
} );

test( 'should partially select with shift + click (@webkit)', async ( {
test( 'should partially select with shift + click', async ( {
page,
editor,
} ) => {
Expand Down
Loading