Update package-lock.json to match 16.4.0 version number #53499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
the
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.5 MB ℹ️ View Unchanged
|
tellthemachines
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Thanks for fixing this! Looks like the version bump didn't go through due to conflicts after the node version upgrade; more info on this Slack thread
|
Thanks for catching! |
|
Thanks folks! I'll open up a follow-up PR to look at updating the Github workflow for version bumps so that the new nested version prop gets updated, too, in subsequent releases. |
|
Follow-up PR to update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update plugin version in
package-lock.jsonto be 16.4.0.Why?
It looks like one line of the bump plugin version in #53489 might have been missed, as the static analysis Github action is currently failing with the following:
I'm wondering if this is related to the npm upgrade in #53426? CC: @youknowriad
How?
Update the affected line.
Separately, in a follow-up we might need to update the
Update plugin versionstep in Github workflows, too:gutenberg/.github/workflows/build-plugin-zip.yml
Line 125 in eb6c362
However, for now, let's see if updating this line allows the Github actions to pass again.
Testing Instructions
Check that Github actions pass, specifically the static analysis job.