-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Classic block: increase dimensions of modal and allow toggling fullscreen #53449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… toggling Update the height so that more content is displayed in the tinymce editor in smaller viewports
ramonjd
added
[Type] Enhancement
A suggestion for improvement.
[Block] Classic
Affects the Classic Editor Block
labels
Aug 9, 2023
Size Change: +356 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice enhancement. Thank you, @ramonjd!
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Classic
Affects the Classic Editor Block
Needs User Documentation
Needs new user documentation
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably resolves #53258
What?
Hi!
This PR:
Why?
Where the classic block contains a lot of content, it can be awkward to edit said content in such a teensy modal window.
Here's what it looks like in trunk:
2023-08-09.15.22.55.mp4
How?
With help from:
headerActions
prop to render buttons in the header #53328And a few CSS tweaks.
Testing Instructions
Screenshots or screencast
2023-08-09.15.17.35.mp4