Selection: restore focus after dragging out of the block repeatedly #53429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -1 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
One line fix with e2e test, so merging. |
3 tasks
SiobhyB
added
the
[Feature] Writing Flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #48747, which is actually not just a problem with the table block. Even when you select inside a paragraph and move out of it multiple times, you end up not being able to type in the paragraph because selection is lost.
Why?
How?
It's a simple fix, we should be checking the event target instead of active element, which doesn't change even after moving out of the block multiple times.
Testing Instructions
Create a paragraph with "ab". Place the caret between these characters and drag forward and out of the paragraph multiple times, releasing the mouse after this with only "a" selected. Press Delete. It should work.
Testing Instructions for Keyboard
Screenshots or screencast