Editor: Use hooks instead of HoCs in PostPendingStatusCheck
#53389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
tyxla
requested review from
Mamaduka,
aristath,
jsnajdr,
flootr,
chad1008,
ntsekouras and
brookewp
tyxla
commented
Aug 7, 2023
| if ( isPublished || ! hasPublishAction ) { | ||
| return null; | ||
| } | ||
|
|
||
| return children; | ||
| } | ||
|
|
||
| export default compose( |
There was a problem hiding this comment.
compose usage was unnecessary here because we were using only one HoC.
| hasPublishAction: | ||
| getCurrentPost()._links?.[ 'wp:action-publish' ] ?? false, | ||
| isPublished: isCurrentPostPublished(), | ||
| postType: getCurrentPostType(), |
There was a problem hiding this comment.
In addition to moving from withSelect, we're no longer returning the postType prop since it was not in use.
|
Size Change: -11 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This straightforward PR updates the
PostPendingStatusCheckcomponent to use the@wordpress/datahooks instead of the HoCs.Related to #53387.
Why?
A micro-optimization to makes the rendered component tree smaller.
How?
We're using the
useSelecthook instead of thewithSelectHoC.Because we're removing a
withSelectand acompose()instance, this removes 2 levels of nesting.Testing Instructions
Creating a new post and editing an existing post, verifying the "Pending review" field in the post sidebar still works well. It should still not appear if a post is already published.
Testing Instructions for Keyboard
None.
Screenshots or screencast
The component tree before:
The component tree after:
