Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type labels GH Action: Fix accessibility issues in error message #53371

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

alexstine
Copy link
Contributor

@alexstine alexstine commented Aug 5, 2023

What?

Fixes accessibility issues in the GH Action message returned when type labels are incorrect.

Why?

We should not have basic accessibility issues in helpful automations.

How?

  • Remove icon.
  • Restructure link text.
  • Remove the heading 2, GitHub has enough headings.

Testing Instructions

Read the code diff.

Testing Instructions for Keyboard

Screenshots or screencast

@alexstine alexstine requested a review from fluiddot August 5, 2023 20:17
@alexstine alexstine self-assigned this Aug 5, 2023
@alexstine alexstine added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). GitHub Actions Pull requests that update GitHub Actions code labels Aug 5, 2023
Co-authored-by: Carlos Garcia <[email protected]>
@alexstine
Copy link
Contributor Author

@fluiddot Looks good. Committed.

Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me 🎊 !

@alexstine alexstine merged commit 30b2659 into trunk Aug 8, 2023
@alexstine alexstine deleted the fix/type-label-a11y branch August 8, 2023 16:23
@github-actions github-actions bot added this to the Gutenberg 16.5 milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). GitHub Actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants