Aspect Ratio: Reset height when selecting the original aspect ratio #53339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Type] Bug
|
Size Change: +96 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in aeb07db. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5761570132
|
|
The failing test is accurate.
If only the height is set, it shouldn't be cleared because the size is defined by the height. EDIT: I think I fixed it. |
If 'Original' is selected, nextAspectRatio is null and still needs to remove the height
Thanks! |
ajlende
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Prevent images from stretching when resetting back to the original aspect ratio.
Why?
On trunk, if an image has a custom aspect ratio, when you select the original aspect ratio the height and with are maintained, which makes the image stretched.
How?
If the user selected the original aspect ratio we remove the height definition, allowing the image to rescale naturally.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast